[ https://issues.apache.org/jira/browse/HDFS-5144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13754320#comment-13754320 ]
Hadoop QA commented on HDFS-5144: --------------------------------- {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12600699/HDFS-5144.patch against trunk revision . {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+0 tests included{color}. The patch appears to be a documentation patch that doesn't require tests. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javadoc{color}. The javadoc tool did not generate any warning messages. {color:green}+1 eclipse:eclipse{color}. The patch built with eclipse:eclipse. {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 1.3.9) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:red}-1 core tests{color}. The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs: org.apache.hadoop.hdfs.server.namenode.TestBackupNode {color:green}+1 contrib tests{color}. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/4913//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/4913//console This message is automatically generated. > Document time unit to NameNodeMetrics.java > ------------------------------------------ > > Key: HDFS-5144 > URL: https://issues.apache.org/jira/browse/HDFS-5144 > Project: Hadoop HDFS > Issue Type: Improvement > Components: documentation > Affects Versions: 2.1.0-beta > Reporter: Akira AJISAKA > Priority: Minor > Labels: newbie > Attachments: HDFS-5144.patch > > > in o.a.h.hdfs.server.namenode.metrics.NameNodeMetrics.java, metrics are > declared as follows: > {code} > @Metric("Duration in SafeMode at startup") MutableGaugeInt safeModeTime; > @Metric("Time loading FS Image at startup") MutableGaugeInt fsImageLoadTime; > {code} > Since some users may confuse which unit (sec or msec) is correct, they should > be documented. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira