[
https://issues.apache.org/jira/browse/HDFS-5146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13754926#comment-13754926
]
Hadoop QA commented on HDFS-5146:
---------------------------------
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12600796/HDFS-5146.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-hdfs-project/hadoop-hdfs.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/4914//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/4914//console
This message is automatically generated.
> JspHelper#bestNode() doesn't handle bad datanodes correctly
> -----------------------------------------------------------
>
> Key: HDFS-5146
> URL: https://issues.apache.org/jira/browse/HDFS-5146
> Project: Hadoop HDFS
> Issue Type: Bug
> Affects Versions: 3.0.0, 2.1.0-beta
> Reporter: Vinay
> Assignee: Vinay
> Attachments: HDFS-5146.patch
>
>
> JspHelper#bestNode() doesn't handle correctly if the chosen datanode is down.
> {code} while (s == null) {
> if (chosenNode == null) {
> do {
> if (doRandom) {
> index = DFSUtil.getRandom().nextInt(nodes.length);
> } else {
> index++;
> }
> chosenNode = nodes[index];
> } while (deadNodes.contains(chosenNode));
> }
> chosenNode = nodes[index];
> {code}
> In this part of the code, choosing the datanode will be done only once.
> If the chosen datanode is down, then definitely exception will be thrown
> instead of re-chosing the available node.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
