[ 
https://issues.apache.org/jira/browse/HDFS-5136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13755306#comment-13755306
 ] 

Jing Zhao commented on HDFS-5136:
---------------------------------

The new patch looks pretty good to me. Only one nit:

{code}
+    if (exports.size() > 0) {
+      for (int i = 0; i < exports.size(); i++) {
{code}

I guess we do not need this if here? Also could you mention what tests have 
been run?

+1 once the comments are addressed.
                
> MNT EXPORT should give the full group list which can mount the exports
> ----------------------------------------------------------------------
>
>                 Key: HDFS-5136
>                 URL: https://issues.apache.org/jira/browse/HDFS-5136
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: nfs
>            Reporter: Brandon Li
>            Assignee: Brandon Li
>         Attachments: HDFS-5136.patch, HDFS-5136.patch.2, HDFS-5136.patch.3
>
>
> Currently MNT.EXPORT command returns empty group list which is considered as 
> "everybody can mount the export". It should return the correctly configured 
> group list.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to