[ 
https://issues.apache.org/jira/browse/HDFS-5162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13757945#comment-13757945
 ] 

Kihwal Lee commented on HDFS-5162:
----------------------------------

[~sureshms]: Will it be a simple matter of adding {{synchronized}} to cache 
entry add methods? Or do you think we should do more fine grained locking? 
Either way it will probably be common only change.
                
> Name node crashes due to improper synchronization in RetryCache
> ---------------------------------------------------------------
>
>                 Key: HDFS-5162
>                 URL: https://issues.apache.org/jira/browse/HDFS-5162
>             Project: Hadoop HDFS
>          Issue Type: Bug
>            Reporter: Kihwal Lee
>            Priority: Blocker
>
> In LightWeightCache#evictExpiredEntries(), the precondition check can fail. 
> [~patwhitey2007] ran a HA failover test and it occurred while the SBN was 
> catching up with edits during a transition to active. This caused NN to 
> terminate.
> Here is my theory: If an RPC handler calls waitForCompletion() and it happens 
> to remove the head of the queue in get(), it will race with 
> evictExpiredEntries() frrom put().

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to