[
https://issues.apache.org/jira/browse/HDFS-5085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13762795#comment-13762795
]
Brandon Li commented on HDFS-5085:
----------------------------------
The new patch look good.
Some minor comments and question:
1. why NfsVerifier.readFlavorAndVerifier doesn't have AUTH_SYS check?
2. SecurityHandler might be a better name than SessionSecurityHandler since
"Session" is an NFSv4 concept. NFSv3 has no session.
3. the change in XDR.readString() is not needed since you also fix
XDR.readVariableOpaque() in the same patch
> Refactor o.a.h.nfs to support different types of authentications
> ----------------------------------------------------------------
>
> Key: HDFS-5085
> URL: https://issues.apache.org/jira/browse/HDFS-5085
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: nfs
> Affects Versions: 3.0.0
> Reporter: Brandon Li
> Assignee: Jing Zhao
> Attachments: HDFS-5085.001.patch, HDFS-5085.002.patch,
> HDFS-5085.003.patch, HDFS-5085.004.patch
>
>
> 1. Add Credentials and Verifier definitions.
> 2. Update Nfs3Interface.java and add SessionSecurityHandler to allow the
> support of different types of authentications.
> 3. Update RpcProgrammNfs3.java to move the original AUTH_SYS authentication
> into the new interfaces.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
