[
https://issues.apache.org/jira/browse/HDFS-5122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13763585#comment-13763585
]
Jing Zhao commented on HDFS-5122:
---------------------------------
The patch looks very good to me. Some minor comments:
1. Need to check the indentation of NameNodeProxies#isHAConfiguration.
2. Looks like we do not need to catch the IOException within
NameNodeProxies#isHAConfiguration. Otherwise the IOException thrown by
getFailoverProxyProviderClass may be swallowed.
3. In WbeHdfsFileSystem#initialize,
{code}
Preconditions.checkNotNull(namenodes);
Preconditions.checkArgument(namenodes.size() > 0,
"Does not contain HA HTTP server");
{code}
may be combined in a single Preconditions.checkState call.
4. In TestWebHDFSForHA.java, LOG has not been used, and it may be better to
declare LOGICAL_NAME outside since in the future we can reuse it.
5. bq. Putting the work of automatically switching to ...
Sounds good. We can add support for client side's failover to
WebHdfsFilesystem in a separate jira.
> WebHDFS should support logical service names in URIs
> ----------------------------------------------------
>
> Key: HDFS-5122
> URL: https://issues.apache.org/jira/browse/HDFS-5122
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: ha, webhdfs
> Affects Versions: 2.1.0-beta
> Reporter: Arpit Gupta
> Assignee: Haohui Mai
> Attachments: HDFS-5122.patch
>
>
> For example if the dfs.nameservices is set to arpit
> {code}
> hdfs dfs -ls webhdfs://arpit:50070/tmp
> or
> hdfs dfs -ls webhdfs://arpit/tmp
> {code}
> does not work
> You have to provide the exact active namenode hostname. On an HA cluster
> using dfs client one should not need to provide the active nn hostname
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
