[
https://issues.apache.org/jira/browse/HDFS-5188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13765200#comment-13765200
]
Tsz Wo (Nicholas), SZE commented on HDFS-5188:
----------------------------------------------
More details about h5188_20130912.patch:
- removes a BlockPlacementPolicy.chooseTarget(..) used only in tests;
- removes another BlockPlacementPolicy.chooseTarget(..) used only once;
- replaces HashMap with Map in parameter declarations;
- removes adjustExcludedNodes(..);
- defines DFS_BLOCK_REPLICATOR_CLASSNAME_KEY and
DFS_BLOCK_REPLICATOR_CLASSNAME_DEFAULT;
- cleans up duplicated code by adding new methods.
> Clean up BlockPlacementPolicy and its implementations
> -----------------------------------------------------
>
> Key: HDFS-5188
> URL: https://issues.apache.org/jira/browse/HDFS-5188
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: namenode
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Attachments: h5188_20130912.patch
>
>
> Below is a list of code cleanup tasks for BlockPlacementPolicy and its
> implementations:
> - Define constants for dfs.block.replicator.classname.
> - Combine adjustExcludedNodes and addToExcludedNodes: subclasses should
> always add all the related nodes in addToExcludedNodes(..).
> - Remove duplicated code.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
