[ 
https://issues.apache.org/jira/browse/HDFS-5191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13765720#comment-13765720
 ] 

Suresh Srinivas commented on HDFS-5191:
---------------------------------------

bq. The overhead of using varargs seems excessive (up to 30x timing wise and 
way more garbage created for the temp arrays using Sun JDK 1.6.0.39) for a 
performance API.
While varargs might be expensive, in the context of current API, I do not think 
the cost you are alluding to seems exaggerated. That said, from clean API 
perspective, if an EnumSet can get the job done, it might be better.
                
> revisit zero-copy API in FSDataInputStream to make it more intuitive
> --------------------------------------------------------------------
>
>                 Key: HDFS-5191
>                 URL: https://issues.apache.org/jira/browse/HDFS-5191
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: hdfs-client, libhdfs
>    Affects Versions: HDFS-4949
>            Reporter: Colin Patrick McCabe
>            Assignee: Colin Patrick McCabe
>
> As per the discussion on HDFS-4953, we should revisit the zero-copy API to 
> make it more intuitive for new users.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to