[
https://issues.apache.org/jira/browse/HDFS-5188?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tsz Wo (Nicholas), SZE updated HDFS-5188:
-----------------------------------------
Attachment: h5188_20130914.patch
Junping, thanks for reviewing the patch.
1. Sure, let's move it.
2. Oops, forgot to remove the debug message.
3. srcPath is useful so that BlockPlacementPolicy can possibly use different
policies for different files. The BlockPlacementPolicyRaid was using it so
that some files are in raid and some files are not.
4. I tried to change it but it is quite involved. Let's change it separately
as the patch is already not small.
Here is a new patch: h5188_20130914.patch
> Clean up BlockPlacementPolicy and its implementations
> -----------------------------------------------------
>
> Key: HDFS-5188
> URL: https://issues.apache.org/jira/browse/HDFS-5188
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: namenode
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Attachments: h5188_20130912b.patch, h5188_20130912.patch,
> h5188_20130914.patch
>
>
> Below is a list of code cleanup tasks for BlockPlacementPolicy and its
> implementations:
> - Define constants for dfs.block.replicator.classname.
> - Combine adjustExcludedNodes and addToExcludedNodes: subclasses should
> always add all the related nodes in addToExcludedNodes(..).
> - Remove duplicated code.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
