[ 
https://issues.apache.org/jira/browse/HDFS-5207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13769506#comment-13769506
 ] 

Hudson commented on HDFS-5207:
------------------------------

FAILURE: Integrated in Hadoop-Mapreduce-trunk #1551 (See 
[https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1551/])
HDFS-5207. In BlockPlacementPolicy.chooseTarget(..), change the writer and the 
excludedNodes parameter types respectively to Node and Set.  Contributed by 
Junping Du (szetszwo: 
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1523875)
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockPlacementPolicy.java
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockPlacementPolicyDefault.java
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockPlacementPolicyWithNodeGroup.java
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeRpcServer.java
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/blockmanagement/TestReplicationPolicy.java
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/blockmanagement/TestReplicationPolicyWithNodeGroup.java
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestAddBlockRetry.java

                
> In BlockPlacementPolicy, update 2 parameters of chooseTarget()
> --------------------------------------------------------------
>
>                 Key: HDFS-5207
>                 URL: https://issues.apache.org/jira/browse/HDFS-5207
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: namenode
>            Reporter: Junping Du
>            Assignee: Junping Du
>             Fix For: 2.3.0
>
>         Attachments: HDFS-5207-v1.patch, HDFS-5207-v2.patch, 
> HDFS-5207-v3.patch, HDFS-5207-v4.patch
>
>
> We should change chooseTarget(..., DatanodeDescriptor writer, ...) to 
> chooseTarget (..., node writer, ...) as the only important property of writer 
> is to identify other nodes' location relationship so more generic one could 
> be better. It also helps to cover cases that client node is not a Datanode. 
> Also, the excluded nodes are not necessary to be a HashMap with the same key 
> and value, Set is more proper in this case.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to