[
https://issues.apache.org/jira/browse/HDFS-5213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13771051#comment-13771051
]
Colin Patrick McCabe commented on HDFS-5213:
--------------------------------------------
bq. Can we rename PathBasedCacheDirectiveWithId to something more general, like
PathBasedCacheDescriptor? Reminiscent of file descriptor.
That's a good idea. I renamed it
bq. [javadoc issues]
Fixed.
bq. getDirective() should be named getDirectiveWithId() (or getDescriptor() if
you use my suggestion).
OK.
bq. [exception text]
Replace all references to "entry" etc. with references to
{{PathBasedCacheDescriptor}}.
bq. For implementing equals, how about comparing getClass() rather than
casting? This means it won't take subclasses, which is normally a good thing
(safe symmetric equals).
good idea
bq. extra mortbay.log import
Another auto-add by eclipse. I wonder if I can blacklist this somehow.
> separate PathBasedCacheEntry and PathBasedCacheDirectiveWithId
> --------------------------------------------------------------
>
> Key: HDFS-5213
> URL: https://issues.apache.org/jira/browse/HDFS-5213
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: datanode, namenode
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Attachments: HDFS-5213-caching.001.patch
>
>
> Since PathBasedCacheEntry is intended to be a private (implementation) class,
> return PathBasedCacheDirectiveWithId from all public APIs instead. Some
> other miscellaneous cleanups in the caching RPC stuff.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
