[
https://issues.apache.org/jira/browse/HDFS-5216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13775928#comment-13775928
]
Hadoop QA commented on HDFS-5216:
---------------------------------
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12604543/HDFS-5216.diff
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-hdfs-project/hadoop-hdfs.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/5023//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/5023//console
This message is automatically generated.
> NumDecomDeadDataNodes not returning correct number of dead decommissioned
> nodes
> --------------------------------------------------------------------------------
>
> Key: HDFS-5216
> URL: https://issues.apache.org/jira/browse/HDFS-5216
> Project: Hadoop HDFS
> Issue Type: Bug
> Affects Versions: 2.1.0-beta
> Reporter: Trevor Lorimer
> Assignee: Trevor Lorimer
> Attachments: HDFS-5216.diff, HDFS-5216.diff
>
>
> For HDFS-4860 I essentially copied the process in
> NamenodejspHelper.generateHealthReport(), so it would be in sync with the
> original dfsHealth.jsp.
> However looking at this now there may be a bug? in
> getNumDecomDeadDataNodes(), where:
> getBlockManager().getDatanodeManager().fetchDatanodes(dead, null, true);
>
> Where the parameter true indicates that decommissioned nodes should be
> removed from the list.
> If the flag is true fetchDatanodes calls removeDecomNodeFromList, which will
> remove a node if an existing datanode does not appear in both include or
> exclude lists and it has been decommissioned.
> If I am looking to return the Number of Dead Decommissioned Nodes, should I
> change the remove decommissioned nodes flag to False? i.e.:
> getBlockManager().getDatanodeManager().fetchDatanodes(null, dead, false);
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
