[
https://issues.apache.org/jira/browse/HDFS-5222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13776190#comment-13776190
]
Tsz Wo (Nicholas), SZE commented on HDFS-5222:
----------------------------------------------
Thanks Arpit and Junping for reviewing the patch.
> ... couple of spurious newlines. ...
I intentionally added the new lines to separate the different groups of fields.
> Shall we rename it to something like: notEnoughSpace? ...
You are right that notEnoughSpace is much better. However, I will remove the
method due to the comment below.
> Shall we remove checking node's remaining ...
Sure, let's remove it.
Here is a new patch: h5222_20130824.patch
> Move block schedule information from DatanodeDescriptor to DatanodeStorageInfo
> ------------------------------------------------------------------------------
>
> Key: HDFS-5222
> URL: https://issues.apache.org/jira/browse/HDFS-5222
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: namenode
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Attachments: h5222_20130819.patch, h5222_20130824.patch
>
>
> In HDFS-4990, the block placement target type was changed from
> DatanodeDescriptor to DatanodeStorageInfo. The block schedule information,
> such as the number of blocks scheduled for replication (i.e.
> getBlocksScheduled()), should be moved from DatanodeDescriptor to
> DatanodeStorageInfo.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
