[
https://issues.apache.org/jira/browse/HDFS-4531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13784376#comment-13784376
]
Ravi Prakash commented on HDFS-4531:
------------------------------------
Hi Vadim! Thanks for your contribution. Here are my comments:
1. Some lines are over 80 characters long
2. Any reason why you chose to write to a file called TestHamlet2 instead of
just TestHamletGenOutput or some such name?
3. testHamletGeToFile should be testHamletGenToFile IMHO
4. Why are you catching and throwing the exception as an IOException? If you
just let the method throws Exception, shouldn't Surefire do the needful?
5. More importantly, I wasn't able to fully comprehend what this unit test is
really testing. Just that the generate method actually generates a file? Does
it verify anything inside that file? You can get the unit test coverage
statistics up very simply using this methodology because a lot of code is being
run, but in truth you are not verifying very much the behavior of that code. As
I see it, we can try to verify the behavior of that code, or if its too much
effort, perhaps just close this JIRA as invalid?
> Cover package org.apache.hadoop.yarn.webapp.hamlet with unit tests
> ------------------------------------------------------------------
>
> Key: HDFS-4531
> URL: https://issues.apache.org/jira/browse/HDFS-4531
> Project: Hadoop HDFS
> Issue Type: Test
> Affects Versions: 3.0.0, 2.0.3-alpha
> Reporter: Vadim Bondarev
> Attachments: HADOOP-4531-branch-0.23-a.patch,
> HADOOP-4531-branch-2-a.patch, HADOOP-4531-trunk-a.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.1#6144)
