[
https://issues.apache.org/jira/browse/HDFS-5190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13785410#comment-13785410
]
Colin Patrick McCabe commented on HDFS-5190:
--------------------------------------------
Thanks, Andrew. This looks good. I see that you are using TableListing to
display usage in some cases. That's a use I hadn't thought of, but it makes
sense. It's also great to see a CLI test for this.
Just one question: can we shorten some of the pool-related command names?
{{hadoop cacheadmin -addCachePool}} could probably be shortened to {{hadoop
cacheadmin -addPool}}.
It's pretty clear that in cacheadmin, the pools we're talking about are cache
pools, I think.
> move cache pool manipulation commands to dfsadmin, add to TestHDFSCLI
> ---------------------------------------------------------------------
>
> Key: HDFS-5190
> URL: https://issues.apache.org/jira/browse/HDFS-5190
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: datanode, namenode
> Reporter: Colin Patrick McCabe
> Assignee: Andrew Wang
> Attachments: hdfs-5190-1.patch
>
>
> As per the discussion in HDFS-5158, we should move the cache pool add,
> remove, list commands into cacheadmin. We also should write a unit test in
> TestHDFSCLI for these commands.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
