[ 
https://issues.apache.org/jira/browse/HDFS-5190?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Wang updated HDFS-5190:
------------------------------

    Attachment: hdfs-5190-2.patch

Shinier new patch attached.

* I took your advice about renaming the pool commands. I also decided to rename 
the {{addPath}} etc commands to {{addDirective}} etc, since I think it makes 
more sense (lots of the help and error text talks about directives). 
{{removeDirective}} should also really be {{removeDescriptor}}, but maybe 
that's okay.
* Added more tests, including coverage for directive commands
* Fixed a removePool bug in CacheManager
* Prettified output messages and exception handling in parts of the CacheAdmin

> move cache pool manipulation commands to dfsadmin, add to TestHDFSCLI
> ---------------------------------------------------------------------
>
>                 Key: HDFS-5190
>                 URL: https://issues.apache.org/jira/browse/HDFS-5190
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: datanode, namenode
>            Reporter: Colin Patrick McCabe
>            Assignee: Andrew Wang
>         Attachments: hdfs-5190-1.patch, hdfs-5190-2.patch
>
>
> As per the discussion in HDFS-5158, we should move the cache pool add, 
> remove, list commands into cacheadmin.  We also should write a unit test in 
> TestHDFSCLI for these commands.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Reply via email to