[
https://issues.apache.org/jira/browse/HDFS-5300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13786557#comment-13786557
]
Hadoop QA commented on HDFS-5300:
---------------------------------
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12606843/HDFS-5300.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-hdfs-project/hadoop-hdfs.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/5096//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/5096//console
This message is automatically generated.
> FSNameSystem#deleteSnapshot() should not check owner in case of permissions
> disabled
> ------------------------------------------------------------------------------------
>
> Key: HDFS-5300
> URL: https://issues.apache.org/jira/browse/HDFS-5300
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: namenode
> Affects Versions: 3.0.0, 2.1.0-beta
> Reporter: Vinay
> Assignee: Vinay
> Attachments: HDFS-5300.patch, HDFS-5300.patch, HDFS-5300.patch
>
>
> FSNameSystem#deleteSnapshot() should not check owner in case of permissions
> disabled
> {code:java} checkOperation(OperationCategory.WRITE);
> if (isInSafeMode()) {
> throw new SafeModeException(
> "Cannot delete snapshot for " + snapshotRoot, safeMode);
> }
> FSPermissionChecker pc = getPermissionChecker();
> checkOwner(pc, snapshotRoot);
> BlocksMapUpdateInfo collectedBlocks = new BlocksMapUpdateInfo();
> List<INode> removedINodes = new ChunkedArrayList<INode>();
> dir.writeLock();{code}
> should check owner only in case of permissions enabled as its done for all
> other operations.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
