[jira] [Commented] (HDFS-5306) Datanode https port is not available at the namenode

[Brandon Li (JIRA)]

    [ 
https://issues.apache.org/jira/browse/HDFS-5306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13787285#comment-13787285
 ] 

Brandon Li commented on HDFS-5306:
----------------------------------

The patch looks good. Another method PBHelper#convert(DatanodeIDProto dn), 
needs to check if the client provides secure port in request to be backward 
compatible, e.g.: 
{noformat}
  public static DatanodeID convert(DatanodeIDProto dn) {
    return new DatanodeID(dn.getIpAddr(), dn.getHostName(), dn.getStorageID(),
        dn.getXferPort(), dn.getInfoPort(),
        dn.hasInfoSecurePort() ? dn.getInfoSecurePort() : 0,
        dn.getIpcPort());
  }
{noformat}

> Datanode https port is not available at the namenode
> ----------------------------------------------------
>
>                 Key: HDFS-5306
>                 URL: https://issues.apache.org/jira/browse/HDFS-5306
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: datanode, namenode
>            Reporter: Suresh Srinivas
>            Assignee: Suresh Srinivas
>         Attachments: HDFS-5306.patch
>
>
> To enable https access, the datanode http server https port is needed in 
> namenode web pages and redirects from the namenode. This jira adds an 
> additional optional field to DatanodeIDProto in hdfs.proto and the 
> corresponding DatanodeID java class.



--
This message was sent by Atlassian JIRA
(v6.1#6144)