[
https://issues.apache.org/jira/browse/HDFS-5323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13789474#comment-13789474
]
Hadoop QA commented on HDFS-5323:
---------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12607373/HDFS-5323.001.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:red}-1 eclipse:eclipse{color}. The patch failed to build with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:red}-1 release audit{color}. The applied patch generated 1
release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-hdfs-project/hadoop-hdfs.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/5138//testReport/
Release audit warnings:
https://builds.apache.org/job/PreCommit-HDFS-Build/5138//artifact/trunk/patchprocess/patchReleaseAuditProblems.txt
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/5138//console
This message is automatically generated.
> Remove some deadcode in BlockManager
> ------------------------------------
>
> Key: HDFS-5323
> URL: https://issues.apache.org/jira/browse/HDFS-5323
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: namenode
> Affects Versions: 2.3.0
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Priority: Minor
> Attachments: HDFS-5323.001.patch
>
>
> {{BlockManager#DEFAULT_MAP_LOAD_FACTOR}} is deadcode. It no longer does
> *anything* since blocks are now stored in a GSet whose size is fixed.
> {{BlocksMap#blocks}} does not need to be volatile. Whenever it is accessed,
> it is accessed under the {{FSNamesystem}} lock. Furthermore, access to this
> data structure is not thread-safe.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
