[ 
https://issues.apache.org/jira/browse/HDFS-5331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13792326#comment-13792326
 ] 

Uma Maheswara Rao G commented on HDFS-5331:
-------------------------------------------

You are right. Make sense of this change.

+1 on the patch.

> make SnapshotDiff.java to a o.a.h.util.Tool interface implementation
> --------------------------------------------------------------------
>
>                 Key: HDFS-5331
>                 URL: https://issues.apache.org/jira/browse/HDFS-5331
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: snapshots
>    Affects Versions: 3.0.0, 2.1.1-beta
>            Reporter: Vinay
>            Assignee: Vinay
>         Attachments: HDFS-5331.patch
>
>
> SnapshotDiff.java is a plain class with main() method now. 
> Convert it to o.a.h.util.Tool interface implementation for better look and 
> usage  in tests in future,



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Reply via email to