[ 
https://issues.apache.org/jira/browse/HDFS-5342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13793169#comment-13793169
 ] 

Jing Zhao commented on HDFS-5342:
---------------------------------

The patch looks good to me. One comment:

In StartupprogressView a new method toJSON() is added. StartupprogressServlet 
also tries to generate Json for the StartupprogressView. Is it possible to let 
these two parts call the same method? If not, could you add javadoc to 
StartupprogressView#toJSON to explain that?

+1 after addressing this.

> Provide more information in the JMX interfaces
> ----------------------------------------------
>
>                 Key: HDFS-5342
>                 URL: https://issues.apache.org/jira/browse/HDFS-5342
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>            Reporter: Haohui Mai
>            Assignee: Haohui Mai
>         Attachments: HDFS-5342.000.patch
>
>
> Today the JMX interface in HDFS only provides a subset of information listed 
> in the WebUI. This jira proposes to augment the JMX interface so that it 
> provides as much information as the Web UI today.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Reply via email to