[ 
https://issues.apache.org/jira/browse/HDFS-5358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13794484#comment-13794484
 ] 

Chris Nauroth commented on HDFS-5358:
-------------------------------------

Can we use uint32 for replication in the protocol?  This would further prevent 
a negative value, and also it would be consistent with the replication field in 
other protocol messages.  (See example below.)

Aside from that, the patch looks good.

{code}
message SetReplicationRequestProto {
  required string src = 1;
  required uint32 replication = 2; // Short: Only 16 bits used
}
{code}

> add 'replication' field to PathBasedCacheDirective
> --------------------------------------------------
>
>                 Key: HDFS-5358
>                 URL: https://issues.apache.org/jira/browse/HDFS-5358
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: namenode
>    Affects Versions: HDFS-4949
>            Reporter: Colin Patrick McCabe
>            Assignee: Colin Patrick McCabe
>         Attachments: HDFS-5358-caching.001.patch
>
>
> Add a 'replication' field to PathBasedCacheDirective, so that administrators 
> can configure how many cached replicas of a block the cluster should try to 
> maintain.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Reply via email to