[ 
https://issues.apache.org/jira/browse/HDFS-5330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13795513#comment-13795513
 ] 

Brandon Li commented on HDFS-5330:
----------------------------------

We could create a method like this to share the retry logic. However, when we 
read the method readdir() and readdirplus(), we might not know there is a 
nested special exception handling inside a try-catch unless we read into this 
method. 
It feels more readable to have a nested try-catch instead of hiding one in a 
method with the only purpose to handles one exception. 

> fix readdir and readdirplus for large directories
> -------------------------------------------------
>
>                 Key: HDFS-5330
>                 URL: https://issues.apache.org/jira/browse/HDFS-5330
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: nfs
>            Reporter: Brandon Li
>            Assignee: Brandon Li
>         Attachments: HDFS-5330.001.patch, HDFS-5330.002.patch, 
> HDFS-5330.003.patch, HDFS-5330.004.patch
>
>
> These two calls need to use cookies to do multiple round trips to namenode to 
> get the complete list of the dirents. Currently implementation passes an 
> inode path as "startAfter" for listPath(), however, namenode doesn't resolve 
> startAfter as an inode path. Better use file name as "startAfter".



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Reply via email to