[
https://issues.apache.org/jira/browse/HDFS-5096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13795644#comment-13795644
]
Colin Patrick McCabe commented on HDFS-5096:
--------------------------------------------
bq. I think there is a risk of NullPointerException on the call to
blockInfo#isComplete...
Good catch, Chris. Fixed.
bq. Are those comments still inverted?
No, but they could do with being clearer. Let me see what I can do.
bq. Super-minor: The comment has two sets of double-slashes.
Fixed.
bq. CacheManager#setCachedLocations: I suspect some kind of synchronization is
needed here...
I thought that this was under the FSN read lock, but reading it more carefully,
I can see that it's actually outside that. Let's move it to
{{getBlockLocationsUpdateTimes}}, since that is done under the lock. (It's
also the function that the other similarly named functions call.)
> Automatically cache new data added to a cached path
> ---------------------------------------------------
>
> Key: HDFS-5096
> URL: https://issues.apache.org/jira/browse/HDFS-5096
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: datanode, namenode
> Reporter: Andrew Wang
> Assignee: Colin Patrick McCabe
> Attachments: HDFS-5096-caching.005.patch,
> HDFS-5096-caching.006.patch, HDFS-5096-caching.009.patch
>
>
> For some applications, it's convenient to specify a path to cache, and have
> HDFS automatically cache new data added to the path without sending a new
> caching request or a manual refresh command.
> One example is new data appended to a cached file. It would be nice to
> re-cache a block at the new appended length, and cache new blocks added to
> the file.
> Another example is a cached Hive partition directory, where a user can drop
> new files directly into the partition. It would be nice if these new files
> were cached.
> In both cases, this automatic caching would happen after the file is closed,
> i.e. block replica is finalized.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
