[
https://issues.apache.org/jira/browse/HDFS-5360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13796339#comment-13796339
]
Andrew Wang commented on HDFS-5360:
-----------------------------------
Hi Shinichi, thanks for reporting this issue and attaching a patch.
* {{arguements}} should be spelled {{arguments}}, here and elsewhere in the file
* Instead of having custom messages per the # of arguments, it's better to just
state "Incorrect number of arguments" and show the usage. With multiple
required arguments, you can't actually be sure which ones are missing.
Thanks for the added tests too, looking real good.
> Improvement of usage message of renameSnapshot and deleteSnapshot
> -----------------------------------------------------------------
>
> Key: HDFS-5360
> URL: https://issues.apache.org/jira/browse/HDFS-5360
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: snapshots
> Affects Versions: 3.0.0
> Reporter: Shinichi Yamashita
> Assignee: Shinichi Yamashita
> Priority: Minor
> Attachments: HDFS-5360.patch
>
>
> When the argument of "hdfs dfs -createSnapshot" comamnd is inappropriate, it
> is displayed as follows.
> {code}
> [hadoop@trunk ~]$ hdfs dfs -createSnapshot
> -createSnapshot: <snapshotDir> is missing.
> Usage: hadoop fs [generic options] -createSnapshot <snapshotDir>
> [<snapshotName>]
> {code}
> On the other hands, the commands of "-renameSnapshot" and "-deleteSnapshot"
> is displayed as follows. And there are not kind for the user.
> {code}
> [hadoop@trunk ~]$ hdfs dfs -renameSnapshot
> renameSnapshot: args number not 3: 0
> [hadoop@trunk ~]$ hdfs dfs -deleteSnapshot
> deleteSnapshot: args number not 2: 0
> {code}
> It changes "-renameSnapshot" and "-deleteSnapshot" to output the message
> which is similar to "-createSnapshot".
--
This message was sent by Atlassian JIRA
(v6.1#6144)
