[ 
https://issues.apache.org/jira/browse/HDFS-5247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13796407#comment-13796407
 ] 

Benoy Antony commented on HDFS-5247:
------------------------------------

Looks good. Fixes a bug seen in our clusters repeatedly.
+1.

Please review and commit.


> Namenode should close editlog and unlock storage when removing failed storage 
> dir
> ---------------------------------------------------------------------------------
>
>                 Key: HDFS-5247
>                 URL: https://issues.apache.org/jira/browse/HDFS-5247
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: namenode
>    Affects Versions: 1.2.1
>            Reporter: zhaoyunjiong
>            Assignee: zhaoyunjiong
>             Fix For: 1.2.1
>
>         Attachments: HDFS-5247-branch-1.2.patch
>
>
> When one of dfs.name.dir failed, namenode didn't close editlog and unlock the 
> storage:
> java    24764 hadoop   78uW  REG 252,32        0 393219 
> /volume1/nn/dfs/in_use.lock (deleted)
> java    24764 hadoop  107u   REG 252,32  1155072 393229 
> /volume1/nn/dfs/current/edits.new (deleted)
> java    24764 hadoop  119u   REG 252,32        0 393238 
> /volume1/nn/dfs/current/fstime.tmp
> java    24764 hadoop  140u   REG 252,32  1761805 393239 
> /volume1/nn/dfs/current/edits
> If this dir is limit of space, then restore this storage may fail.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Reply via email to