[ 
https://issues.apache.org/jira/browse/HDFS-5358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13797130#comment-13797130
 ] 

Chris Nauroth commented on HDFS-5358:
-------------------------------------

Thanks, Andrew.  I just committed a fix.  The problem was that editsStored 
didn't have the replication field on the {{AddPathBasedCacheDirectiveOp}}, so 
it would fail in deserialization.  The editsStored.xml file was already updated 
to include replication though.  The easiest thing to do was to run offline 
edits viewer to convert editsStored.xml to editsStored binary and check that in.

Note however that the test won't pass until HDFS-5096 goes in.  During that 
code review, we found a {{NullPointerException}} in {{setCacheReplication}}.  
It made sense to fix it over there along with all of the refactoring that 
happened.

> Add replication field to PathBasedCacheDirective
> ------------------------------------------------
>
>                 Key: HDFS-5358
>                 URL: https://issues.apache.org/jira/browse/HDFS-5358
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: namenode
>    Affects Versions: HDFS-4949
>            Reporter: Colin Patrick McCabe
>            Assignee: Colin Patrick McCabe
>             Fix For: HDFS-4949
>
>         Attachments: HDFS-5358-caching.001.patch, HDFS-5358-caching.002.patch
>
>
> Add a 'replication' field to PathBasedCacheDirective, so that administrators 
> can configure how many cached replicas of a block the cluster should try to 
> maintain.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Reply via email to