[
https://issues.apache.org/jira/browse/HDFS-4885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13799334#comment-13799334
]
Tsz Wo (Nicholas), SZE commented on HDFS-4885:
----------------------------------------------
> Nicholas suggested offline that we simply pass in the replication number ...
More details: BlockPlacementPolicy.verifyBlockPlacement(..) should not refer to
HdfsFileStatus as the entire block management layer should not refer to
namenode specific implementation so that the block management could possibly
support other namespace implementations.
> We'll probably need to introduce a new API to verify RAID block replacement,
> ...
For RAID, the facebook implementation use srcPath to determine block placement.
So the current API may be good enough.
> Update verifyBlockPlacement() API in BlockPlacementPolicy
> ---------------------------------------------------------
>
> Key: HDFS-4885
> URL: https://issues.apache.org/jira/browse/HDFS-4885
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Junping Du
> Assignee: Junping Du
> Labels: BlockPlacementPolicy
> Attachments: HDFS-4885.patch, HDFS-4885-v2.patch, HDFS-4885-v3.patch
>
>
> verifyBlockPlacement() has unused parameter -srcPath as its responsibility
> just verify single block rather than files under a specific path. Also the
> return value (int) does not make sense as the violation of block placement
> has other case than number of racks, so boolean value should be better.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
