[
https://issues.apache.org/jira/browse/HDFS-4265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13802829#comment-13802829
]
Hadoop QA commented on HDFS-4265:
---------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12609843/002-HDFS-4265.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:red}-1 eclipse:eclipse{color}. The patch failed to build with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:red}-1 release audit{color}. The applied patch generated 1
release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests in
hadoop-hdfs-project/hadoop-hdfs/src/contrib/bkjournal:
org.apache.hadoop.contrib.bkjournal.TestBookKeeperEditLogStreams
org.apache.hadoop.contrib.bkjournal.TestBookKeeperAsHASharedDir
org.apache.hadoop.contrib.bkjournal.TestBookKeeperHACheckpoints
org.apache.hadoop.contrib.bkjournal.TestBookKeeperJournalManager
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/5262//testReport/
Release audit warnings:
https://builds.apache.org/job/PreCommit-HDFS-Build/5262//artifact/trunk/patchprocess/patchReleaseAuditProblems.txt
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/5262//console
This message is automatically generated.
> BKJM doesn't take advantage of speculative reads
> ------------------------------------------------
>
> Key: HDFS-4265
> URL: https://issues.apache.org/jira/browse/HDFS-4265
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ha
> Affects Versions: 2.2.0
> Reporter: Ivan Kelly
> Assignee: Rakesh R
> Attachments: 001-HDFS-4265.patch, 002-HDFS-4265.patch
>
>
> BookKeeperEditLogInputStream reads entry at a time, so it doesn't take
> advantage of the speculative read mechanism introduced by BOOKKEEPER-336.
--
This message was sent by Atlassian JIRA
(v6.1#6144)