[
https://issues.apache.org/jira/browse/HDFS-5413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13805637#comment-13805637
]
Chris Nauroth commented on HDFS-5413:
-------------------------------------
{quote}
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
{quote}
The patch contains only script changes, so there are no new tests. I tested
manually in a cluster running on Windows by running all hdfs.cmd sub-commands
and one direct class to cover the passthrough case.
{quote}
-1 core tests. The patch failed these unit tests in
hadoop-hdfs-project/hadoop-hdfs:
org.apache.hadoop.hdfs.server.blockmanagement.TestBlocksWithNotEnoughRacks
{quote}
This test is known to be flaky.
> hdfs.cmd does not support passthrough to any arbitrary class.
> -------------------------------------------------------------
>
> Key: HDFS-5413
> URL: https://issues.apache.org/jira/browse/HDFS-5413
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: scripts
> Affects Versions: 3.0.0, 2.2.0
> Reporter: Chris Nauroth
> Assignee: Chris Nauroth
> Attachments: HDFS-5413.1.patch, HDFS-5413.2.patch
>
>
> The hdfs shell script supports passthrough to calling any arbitrary class if
> the first argument is not one of the per-defined sub-commands. The
> equivalent cmd script does not implement this and instead fails trying to do
> a labeled goto to the first argument.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
