[
https://issues.apache.org/jira/browse/HDFS-5433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13806034#comment-13806034
]
Hadoop QA commented on HDFS-5433:
---------------------------------
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12610445/HDFS-5433.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-hdfs-project/hadoop-hdfs.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/5289//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/5289//console
This message is automatically generated.
> When reloading fsimage during checkpointing, we should clear existing
> snapshottable directories
> -----------------------------------------------------------------------------------------------
>
> Key: HDFS-5433
> URL: https://issues.apache.org/jira/browse/HDFS-5433
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: snapshots
> Affects Versions: 2.2.0
> Reporter: Aaron T. Myers
> Assignee: Aaron T. Myers
> Priority: Critical
> Attachments: HDFS-5433.patch
>
>
> The complete set of snapshottable directories are referenced both via the
> file system tree and in the SnapshotManager class. It's possible that when
> the 2NN performs a checkpoint, it will reload its in-memory state based on a
> new fsimage from the NN, but will not clear the set of snapshottable
> directories referenced by the SnapshotManager. In this case, the 2NN will
> write out an fsimage that cannot be loaded, since the integer written to the
> fsimage indicating the number of snapshottable directories will be out of
> sync with the actual number of snapshottable directories serialized to the
> fsimage.
> This is basically the same as HDFS-3835, but for snapshottable directories
> instead of delegation tokens.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
