[
https://issues.apache.org/jira/browse/HDFS-5252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13807709#comment-13807709
]
Hadoop QA commented on HDFS-5252:
---------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12610767/HDFS-5252.001.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-hdfs-project/hadoop-hdfs-nfs.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/5303//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/5303//console
This message is automatically generated.
> Stable write is not handled correctly in someplace
> --------------------------------------------------
>
> Key: HDFS-5252
> URL: https://issues.apache.org/jira/browse/HDFS-5252
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: nfs
> Reporter: Brandon Li
> Assignee: Brandon Li
> Attachments: HDFS-5252.001.patch
>
>
> When the client asks for a stable write but the prerequisite writes are not
> transferred to NFS gateway, the stableness can't be honored. NFS gateway has
> to treat the write as unstable write and set the flag to UNSTABLE in the
> write response.
> One bug was found during test with Ubuntu client when copying one 1KB file.
> For small files like 1KB file, Ubuntu client does one stable write (with
> FILE_SYNC flag). However, NFS gateway missed one place
> where(OpenFileCtx#doSingleWrite) it sends response with the flag NOT updated
> to UNSTABLE.
> With this bug, the client thinks the write is on disk and thus doesn't send
> COMMIT anymore. The following test tries to read the data back and of course
> fails to do so since the data was not synced.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
