[ 
https://issues.apache.org/jira/browse/HDFS-5452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13812409#comment-13812409
 ] 

Arpit Agarwal commented on HDFS-5452:
-------------------------------------

+1 for the patch.

I verified it fixes TestBlocksScheduledCounter. It looks like one test case is 
still failing in TestReplicationPolicy. We can fix it in a separate Jira.

{code}
java.lang.NullPointerException: null
        at 
org.apache.hadoop.hdfs.server.blockmanagement.TestReplicationPolicy.testChooseTargetWithMoreThanHalfStaleNodes(TestReplicationPolicy.java:611)
{code}

> Fix TestReplicationPolicy and TestBlocksScheduledCounter
> --------------------------------------------------------
>
>                 Key: HDFS-5452
>                 URL: https://issues.apache.org/jira/browse/HDFS-5452
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: namenode
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Tsz Wo (Nicholas), SZE
>         Attachments: h5452_20131101.patch
>
>
> TestReplicationPolicy: the log level checking is incorrect.
> TestBlocksScheduledCounter: HDFS-5222, which moved block schedule information 
> from DatanodeDescriptor to DatanodeStorageInfo, is incorrect since a replica 
> scheduled to a storage may eventually be written to another storage in the 
> same datanode.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Reply via email to