[ 
https://issues.apache.org/jira/browse/HDFS-5326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13815326#comment-13815326
 ] 

Colin Patrick McCabe commented on HDFS-5326:
--------------------------------------------

* {{TestClientNamenodeProtocolServerSideTranslatorPB}}: we don't need this test 
any more since validation is done server-side.  Rationale: I would rather keep 
the validation in one place than have it spread out across client and server.  
It *must* be on the server, since we can't trust arbitrary clients, so let's 
just put it all there and unit test it well.

* {{TestOfflineEditsViewer}}: I think this test failure happened because 
jenkins didn't apply the git binary diff to the {{editsStored}} file.  I don't 
think the version of GNU patch used by jenkins supports git binary diffs.  
We've seen this in the past when updating this test.

* added modifyPBCD test to {{TestPathBasedCacheRequests}}.
 
* Fix bug where we were assuming that all modify requests came with a path.

> add modifyDirective to cacheAdmin
> ---------------------------------
>
>                 Key: HDFS-5326
>                 URL: https://issues.apache.org/jira/browse/HDFS-5326
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: datanode, namenode
>    Affects Versions: 3.0.0
>            Reporter: Colin Patrick McCabe
>            Assignee: Colin Patrick McCabe
>         Attachments: HDFS-5326.003.patch, HDFS-5326.004.patch
>
>
> We should add a way of modifying cache directives on the command-line, 
> similar to how modifyCachePool works.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Reply via email to