[ 
https://issues.apache.org/jira/browse/HDFS-5464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13815385#comment-13815385
 ] 

Konstantin Shvachko commented on HDFS-5464:
-------------------------------------------

> you won't argue that the new code is simpler than the existing

Agreed on simpler. :-)

>  see if I could come up a better solution

Sure would be interesting to see. I doubt much can be done in this respect. We 
need to find blocks that did not appear in the report: in one pass and with 
constant memory overhead. May be an interview question.

> Simplify block report diff calculation
> --------------------------------------
>
>                 Key: HDFS-5464
>                 URL: https://issues.apache.org/jira/browse/HDFS-5464
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: namenode
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Tsz Wo (Nicholas), SZE
>            Priority: Minor
>         Attachments: h5464_20131105.patch, h5464_20131105b.patch, 
> h5464_20131105c.patch
>
>
> The current calculation in BlockManager.reportDiff(..) is unnecessarily 
> complicated.  We could simplify the calculation.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Reply via email to