[ 
https://issues.apache.org/jira/browse/HDFS-5470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13815452#comment-13815452
 ] 

Tsz Wo (Nicholas), SZE commented on HDFS-5470:
----------------------------------------------

The advantage for (non-static) inner class is to access the enclosing class 
object by using "this" reference.  Just like methods, we may make all methods 
static and pass the enclosing object as a parameter.  I beg you won't think 
that it is a good design.

BTW, Java ArrayList.Itr is also non-static
http://grepcode.com/file/repository.grepcode.com/java/root/jdk/openjdk/7-b147/java/util/ArrayList.java#ArrayList.Itr

> Add back trunk's reportDiff algorithm to HDFS-2832
> --------------------------------------------------
>
>                 Key: HDFS-5470
>                 URL: https://issues.apache.org/jira/browse/HDFS-5470
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Tsz Wo (Nicholas), SZE
>         Attachments: h5470_20131106.patch
>
>
> As reminded by [~shv] in HDFS-5464, the report diff algorithm uses less 
> memory.  It also has a faster running time.  We should add it back to the 
> branch.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Reply via email to