[ 
https://issues.apache.org/jira/browse/HDFS-5326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13816211#comment-13816211
 ] 

Andrew Wang commented on HDFS-5326:
-----------------------------------

bq. <reordering methods>

I think you missed one reordering in FSEditLog :)

bq. Let's do this as part of HDFS-5471 if it looks good... similarly with 
refactoring pc#checkPermission.

OK, I'll cross post my cleanup comments there.

+1 once addressed (and the Findbugs warning), thanks Colin.

> add modifyDirective to cacheAdmin
> ---------------------------------
>
>                 Key: HDFS-5326
>                 URL: https://issues.apache.org/jira/browse/HDFS-5326
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: datanode, namenode
>    Affects Versions: 3.0.0
>            Reporter: Colin Patrick McCabe
>            Assignee: Colin Patrick McCabe
>         Attachments: HDFS-5326.003.patch, HDFS-5326.004.patch, 
> HDFS-5326.006.patch, HDFS-5326.007.patch
>
>
> We should add a way of modifying cache directives on the command-line, 
> similar to how modifyCachePool works.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Reply via email to