[ 
https://issues.apache.org/jira/browse/HDFS-5476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13816954#comment-13816954
 ] 

Hadoop QA commented on HDFS-5476:
---------------------------------

{color:green}+1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12612754/HDFS-5476.001.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:green}+1 tests included{color}.  The patch appears to include 2 new 
or modified test files.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with 
eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in 
hadoop-hdfs-project/hadoop-hdfs.

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-HDFS-Build/5359//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/5359//console

This message is automatically generated.

> Snapshot: clean the blocks/files/directories under a renamed file/directory 
> while deletion
> ------------------------------------------------------------------------------------------
>
>                 Key: HDFS-5476
>                 URL: https://issues.apache.org/jira/browse/HDFS-5476
>             Project: Hadoop HDFS
>          Issue Type: Bug
>    Affects Versions: 2.2.0
>            Reporter: Jing Zhao
>            Assignee: Jing Zhao
>         Attachments: HDFS-5476.001.patch
>
>
> Currently DstReference#destroyAndCollectBlocks may fail to clean the subtree 
> under the DstReference node for file/directory/snapshot deletion.
> Use case 1:
> # rename under-construction file with 0-sized blocks after snapshot.
> # delete the renamed directory.
> We need to make sure we delete the 0-sized block.
> Use case 2:
> # create snapshot s0 for /
> # create a new file under /foo/bar/
> # rename foo --> foo2
> # create snapshot s1
> # delete bar and foo2
> # delete snapshot s1
> We need to make sure we delete the file under /foo/bar since it is not 
> included in snapshot s0.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Reply via email to