[
https://issues.apache.org/jira/browse/HDFS-5440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13817907#comment-13817907
]
Jing Zhao commented on HDFS-5440:
---------------------------------
The patch looks good to me. One nit is that "TokenManagementDelgator" should be
renamed to "TokenManagementDelegator".
Looks like all the other code is just moving/refactoring the code, except that
now in HftpFileSystem, we no longer maintain two tokens (renewToken and
delegationToken), which originally have two different types of TokenKind: one
with "hftp" which is used for token renewal and cancellation, one with "hdfs"
which is used for normal operation (included in query as token parameter). With
the patch, we will only have one token with the kind "hftp".
Looks like the NN server side does not check Token#kind currently. Also the
patch works fine for normal HftpFileSystem operations (with secure setup). So
this change looks fine to me. [~daryn], could you please just verify that this
change is OK? In the meanwhile, we will also test distcp in secured cluster
with the patch.
If the test goes fine, I will commit the patch next Monday evening in case that
there is no more comment.
> Extract the logic of handling delegation tokens in HftpFileSystem to the
> TokenAspect class
> ------------------------------------------------------------------------------------------
>
> Key: HDFS-5440
> URL: https://issues.apache.org/jira/browse/HDFS-5440
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Haohui Mai
> Assignee: Haohui Mai
> Attachments: HDFS-5440.000.patch, HDFS-5440.001.patch
>
>
> The logic of handling delegation token in HftpFileSystem and
> WebHdfsFileSystem are mostly identical. To simplify the code, this jira
> proposes to extract the common code into a new class named TokenAspect.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
