[ 
https://issues.apache.org/jira/browse/HDFS-5471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13818839#comment-13818839
 ] 

Hadoop QA commented on HDFS-5471:
---------------------------------

{color:green}+1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12613106/hdfs-5471-1.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:green}+1 tests included{color}.  The patch appears to include 1 new 
or modified test files.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with 
eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in 
hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs.

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-HDFS-Build/5385//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/5385//console

This message is automatically generated.

> CacheAdmin -listPools fails when user lacks permissions to view all pools
> -------------------------------------------------------------------------
>
>                 Key: HDFS-5471
>                 URL: https://issues.apache.org/jira/browse/HDFS-5471
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: tools
>    Affects Versions: 3.0.0
>            Reporter: Stephen Chu
>            Assignee: Andrew Wang
>         Attachments: hdfs-5471-1.patch
>
>
> When a user does not have read permissions to a cache pool and executes "hdfs 
> cacheadmin -listPools" the command will error complaining about missing 
> required fields with something like:
> {code}
> [schu@hdfs-nfs ~]$ hdfs cacheadmin -listPools
> Exception in thread "main" 
> org.apache.hadoop.ipc.RemoteException(org.apache.hadoop.ipc.RemoteException): 
> Message missing required fields: ownerName, groupName, mode, weight
>       at 
> com.google.protobuf.AbstractMessage$Builder.newUninitializedMessageException(AbstractMessage.java:770)
>       at 
> org.apache.hadoop.hdfs.protocol.proto.ClientNamenodeProtocolProtos$ListCachePoolsResponseElementProto$Builder.build(ClientNamenodeProtocolProtos.java:51722)
>       at 
> org.apache.hadoop.hdfs.protocolPB.ClientNamenodeProtocolServerSideTranslatorPB.listCachePools(ClientNamenodeProtocolServerSideTranslatorPB.java:1200)
>       at 
> org.apache.hadoop.hdfs.protocol.proto.ClientNamenodeProtocolProtos$ClientNamenodeProtocol$2.callBlockingMethod(ClientNamenodeProtocolProtos.java)
>       at 
> org.apache.hadoop.ipc.ProtobufRpcEngine$Server$ProtoBufRpcInvoker.call(ProtobufRpcEngine.java:605)
>       at org.apache.hadoop.ipc.RPC$Server.call(RPC.java:932)
>       at org.apache.hadoop.ipc.Server$Handler$1.run(Server.java:2057)
>       at org.apache.hadoop.ipc.Server$Handler$1.run(Server.java:2053)
>       at java.security.AccessController.doPrivileged(Native Method)
>       at javax.security.auth.Subject.doAs(Subject.java:396)
>       at 
> org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1515)
>       at org.apache.hadoop.ipc.Server$Handler.run(Server.java:2051)
>       at 
> org.apache.hadoop.hdfs.tools.CacheAdmin$ListCachePoolsCommand.run(CacheAdmin.java:675)
>       at org.apache.hadoop.hdfs.tools.CacheAdmin.run(CacheAdmin.java:85)
>       at org.apache.hadoop.hdfs.tools.CacheAdmin.main(CacheAdmin.java:90)
> [schu@hdfs-nfs ~]$ 
> {code}
> In this example, the pool "root" has 750 permissions, and the root superuser 
> is able to successfully -listPools:
> {code}
> [root@hdfs-nfs ~]# hdfs cacheadmin -listPools
> Found 4 results.
> NAME  OWNER  GROUP  MODE       WEIGHT 
> bar   root   root   rwxr-xr-x  100    
> foo   root   root   rwxr-xr-x  100    
> root  root   root   rwxr-x---  100    
> schu  root   root   rwxr-xr-x  100    
> [root@hdfs-nfs ~]# 
> {code}
> When we modify the root pool to mode 755, schu user can now -listPools 
> successfully without error.
> {code}
> [schu@hdfs-nfs ~]$ hdfs cacheadmin -listPools
> Found 4 results.
> NAME  OWNER  GROUP  MODE       WEIGHT 
> bar   root   root   rwxr-xr-x  100    
> foo   root   root   rwxr-xr-x  100    
> root  root   root   rwxr-xr-x  100    
> schu  root   root   rwxr-xr-x  100    
> [schu@hdfs-nfs ~]$ 
> {code}



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Reply via email to