[
https://issues.apache.org/jira/browse/HDFS-5485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13819675#comment-13819675
]
Andrew Wang commented on HDFS-5485:
-----------------------------------
Nice one, thanks Colin. Some comments:
* For the usage line, I think the convention is to use surround optional
arguments with square brackets. At least that's what I did for the other
commands.
* Could you add tests for modifying the other fields too? Just for completeness.
+1 once addressed.
> add command-line support for modifyDirective
> --------------------------------------------
>
> Key: HDFS-5485
> URL: https://issues.apache.org/jira/browse/HDFS-5485
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: hdfs-client
> Affects Versions: 3.0.0
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Attachments: HDFS-5485.001.patch
>
>
> add command-line support for modifyDirective
--
This message was sent by Atlassian JIRA
(v6.1#6144)
