[
https://issues.apache.org/jira/browse/HDFS-5495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13819722#comment-13819722
]
Hadoop QA commented on HDFS-5495:
---------------------------------
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12613258/HDFS-5495-trunk.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 18 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-httpfs
hadoop-hdfs-project/hadoop-hdfs-nfs.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/5390//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/5390//console
This message is automatically generated.
> Remove further JUnit3 usages from HDFS
> --------------------------------------
>
> Key: HDFS-5495
> URL: https://issues.apache.org/jira/browse/HDFS-5495
> Project: Hadoop HDFS
> Issue Type: Improvement
> Affects Versions: 3.0.0, 2.2.0
> Reporter: Andrew Wang
> Assignee: Jarek Jarcec Cecho
> Labels: newbie
> Attachments: HDFS-5495-trunk.patch
>
>
> We're trying to move away from junit3 in hadoop to junit4. One easy way of
> testing for this is something like the following:
> {code}
> -> % ack junit.framework -l
> hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestAbandonBlock.java
> hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestConnCache.java
> hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSClientExcludedNodes.java
> hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSOutputStream.java
> hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestFileInputStreamCache.java
> hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestBlockReport.java
> hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestCachingStrategy.java
> hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestFsDatasetCache.java
> hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestMultipleNNDataBlockScanner.java
> hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/TestAvailableSpaceVolumeChoosingPolicy.java
> hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestPathBasedCacheRequests.java
> hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/util/TestXMLUtils.java
> hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/web/TestURLConnectionFactory.java
> hadoop-hdfs/src/test/java/org/apache/hadoop/net/TestNetworkTopology.java
> hadoop-hdfs-httpfs/src/test/java/org/apache/hadoop/fs/http/server/TestHttpFSKerberosAuthenticationHandler.java
> hadoop-hdfs-httpfs/src/test/java/org/apache/hadoop/fs/http/server/TestHttpFSWithKerberos.java
> hadoop-hdfs-httpfs/src/test/java/org/apache/hadoop/lib/service/security/TestDelegationTokenManagerService.java
> hadoop-hdfs-nfs/src/test/java/org/apache/hadoop/hdfs/nfs/nfs3/TestWrites.java
> {code}
> Most of these are probably just static assert imports, it's fairly mechanical
> to use the JUnit4 versions. Same goes for converting the unit tests (if
> necessary).
> See HDFS-3583 and HDFS-3711 for the history.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
