[
https://issues.apache.org/jira/browse/HDFS-5428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13822342#comment-13822342
]
Vinay commented on HDFS-5428:
-----------------------------
Patch looks pretty good.
Anyway I did not observe the mentioned issue in previous patch also. Need to
check more.
Here are some small nits
1. BlockInfoUnderConstruction could be replaced with another simple constructor
with only 2 parameters
{noformat}
+ BlockInfo lastBlk = blocks[blocks.length - 1];
+ blocks[blocks.length - 1] = new BlockInfoUnderConstruction(
+ lastBlk, replication, BlockUCState.UNDER_CONSTRUCTION, null);
+ }{noformat}
2. changes in FSImageSerialization.java are only whitespace and format,
unrelated to this patch. I think it can be removed from current patch
> under construction files deletion after snapshot+checkpoint+nn restart leads
> nn safemode
> ----------------------------------------------------------------------------------------
>
> Key: HDFS-5428
> URL: https://issues.apache.org/jira/browse/HDFS-5428
> Project: Hadoop HDFS
> Issue Type: Bug
> Affects Versions: 3.0.0, 2.2.0
> Reporter: Vinay
> Assignee: Vinay
> Attachments: HDFS-5428-v2.patch, HDFS-5428.000.patch,
> HDFS-5428.001.patch, HDFS-5428.002.patch, HDFS-5428.patch
>
>
> 1. allow snapshots under dir /foo
> 2. create a file /foo/test/bar and start writing to it
> 3. create a snapshot s1 under /foo after block is allocated and some data has
> been written to it
> 4. Delete the directory /foo/test
> 5. wait till checkpoint or do saveNameSpace
> 6. restart NN.
> NN enters to safemode.
> Analysis:
> Snapshot nodes loaded from fsimage are always complete and all blocks will be
> in COMPLETE state.
> So when the Datanode reports RBW blocks those will not be updated in
> blocksmap.
> Some of the FINALIZED blocks will be marked as corrupt due to length mismatch.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
