[
https://issues.apache.org/jira/browse/HDFS-5451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13827339#comment-13827339
]
Andrew Wang commented on HDFS-5451:
-----------------------------------
Haven't checked the new patch yet, just replying to comments:
bq. as per our discussion earlier, I'd rather not create more subclasses. Users
should be able to get back a PBCD from listDirectives, modify one thing, and
then use it in modifyDirective.
Is the subclass that gross here? You could PBCD.Builder(subclass) still to seed
the PBCD for modification, and thus hide the new setter/getters. Just thinking
about how we might clean up the API.
bq. I don't want to do so much copying. This list could have arbitrary length.
This can't go in DFSUtil since it depends on the configuration value for
maximum blocks to print.
Yea, you're right on the copying. Didn't realize that. You could pass the
config param in to the function to put this in DFSUtil still; there are other
functions like this one there, which is why I suggested it.
bq. Let's do that later. It's not really related to the other changes here and
we want the stats in soon.
Could you file the follow on JIRA then? thanks.
> add more debugging for cache rescan
> -----------------------------------
>
> Key: HDFS-5451
> URL: https://issues.apache.org/jira/browse/HDFS-5451
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: datanode, namenode
> Affects Versions: 3.0.0
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Attachments: HDFS-5451.001.patch, HDFS-5451.002.patch,
> HDFS-5451.003.patch
>
>
> It would be nice to have message at DEBUG level that described all the
> decisions we made for cache entries. That way we could turn on this
> debugging to get more information. We should also store the number of bytes
> each PBCE wanted, and the number of bytes it got, plus the number of inodes
> it got, and output those in {{listDirectives}}.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
