[
https://issues.apache.org/jira/browse/HDFS-5542?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tsz Wo (Nicholas), SZE updated HDFS-5542:
-----------------------------------------
Attachment: h5542_20131121.patch
h5542_20131121.patch: also changes the following:
- renames test method with "ForTesting" suffix;
- throws IllegalStateException if it fails to convert to and from PB;
- changes DatanodeStorageInfo.state to final (we assume storage won't change
state);
- replaces AbstractList and ArrayList with List;
- throws IllegalArgumentException if it fails to parse storage location
specified in conf;
- adds \[default = DISK] to DatanodeStorageProto.
> Fix TODO and clean up the code in HDFS-2832.
> --------------------------------------------
>
> Key: HDFS-5542
> URL: https://issues.apache.org/jira/browse/HDFS-5542
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Priority: Minor
> Attachments: h5542_20131121.patch
>
>
> - Fix TODOs.
> - Remove unused code.
> - Reduce visibility (e.g. change public to package private.)
> - Simplify the code if possible.
> - Fix comments and javadoc.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
