[
https://issues.apache.org/jira/browse/HDFS-5537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13833250#comment-13833250
]
Tsz Wo (Nicholas), SZE commented on HDFS-5537:
----------------------------------------------
- FileDiff should extend AbstractINodeDiff<INodeFileWithSnapshot,
INodeFileAttributes, FileDiff>. Then, many of castings from INodeFile to
INodeFileWithSnapshot are unnecessary. However, given that we will replace
INodeFileWithSnapshot with something like FileWithSnapshotFeature. I am fine
if you want to keep it as-is.
- Add @override to INodeFileWithSnapshot.getBlockReplication().
- There are a lot of white space changes in INode and INodeFile. I suspect you
have accidently triggered some shortcut in your IDE.
> Remove FileWithSnapshot interface
> ---------------------------------
>
> Key: HDFS-5537
> URL: https://issues.apache.org/jira/browse/HDFS-5537
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: namenode
> Reporter: Jing Zhao
> Assignee: Jing Zhao
> Attachments: HDFS-5537.000.patch, HDFS-5537.001.patch,
> HDFS-5537.002.patch, HDFS-5537.003.patch, HDFS-5537.003.patch
>
>
> We use the FileWithSnapshot interface to define a set of methods shared by
> INodeFileWithSnapshot and INodeFileUnderConstructionWithSnapshot. After using
> the Under-Construction feature to replace the INodeFileUC and
> INodeFileUCWithSnapshot, we no longer need this interface.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
