[ https://issues.apache.org/jira/browse/HDFS-5568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13833299#comment-13833299 ]
Vinay commented on HDFS-5568: ----------------------------- bq. One comment is the following code cannot cover the case that the initial given path for fsck is under a snapshottable directory. Yes. -includeSnapshots is to include the ".snapshot" directory and its tree if the path is a snapshottable directory. Not to find out the corresponding snapshot path of directory/files under a snapshottable directory and include them in fsck report. If the path is not exactly a snapshottable directory or a parent of it, then fsck will not include any ".snapshot" paths in it. > Support inclusion of snapshot paths in Namenode fsck > ---------------------------------------------------- > > Key: HDFS-5568 > URL: https://issues.apache.org/jira/browse/HDFS-5568 > Project: Hadoop HDFS > Issue Type: Improvement > Components: snapshots > Reporter: Vinay > Assignee: Vinay > Attachments: HDFS-5568-1.patch, HDFS-5568.patch, HDFS-5568.patch > > > Support Fsck to check the snapshot paths also for inconsistency. > Currently Fsck supports snapshot paths if path given explicitly refers to a > snapshot path. > We have seen safemode problems in our clusters which were due to blocks > missing which were only present inside snapshots. But "hdfs fsck /" shows > HEALTHY. > So supporting snapshot paths also during fsck (may be by default or on > demand) would be helpful in these cases instead of specifying each and every > snapshottable directory. -- This message was sent by Atlassian JIRA (v6.1#6144)