[
https://issues.apache.org/jira/browse/HDFS-5545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13833302#comment-13833302
]
Jing Zhao commented on HDFS-5545:
---------------------------------
The patch looks pretty good. Some comments:
# Builder#hostName should be declared as private
# HttpServer#AddUnmanagedListener and HttpServer#AddManagedListener, method
names should be addxxxxx, and these two methods can be renamed to
addExternalListener and addListener.
# Add javadoc for ListenerInfo and explain the meaning of its field isManaged.
# The following code should use the given "hostName" instead of
"listeners.get(0).listener.getHost()"?
{code}
- params.put("kerberos.principal",
- SecurityUtil.getServerPrincipal(principalInConf,
listener.getHost()));
+ params.put("kerberos.principal", SecurityUtil.getServerPrincipal(
+ principalInConf, listeners.get(0).listener.getHost()));
{code}
# The change in NameNode.java is an empty line.
# Please mention your system tests.
> Allow specifying endpoints for listeners in HttpServer
> ------------------------------------------------------
>
> Key: HDFS-5545
> URL: https://issues.apache.org/jira/browse/HDFS-5545
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Haohui Mai
> Assignee: Haohui Mai
> Attachments: HDFS-5545.000.patch, HDFS-5545.001.patch,
> HDFS-5545.002.patch
>
>
> Currently HttpServer listens to HTTP port and provides a method to allow the
> users to add an SSL listeners after the server starts. This complicates the
> logic if the client needs to set up HTTP / HTTPS serverfs.
> This jira proposes to replace these two methods with the concepts of listener
> endpoints. A listener endpoints is a URI (i.e., scheme + host + port) that
> the HttpServer should listen to. This concept simplifies the task of managing
> the HTTP server from HDFS / YARN.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
