[
https://issues.apache.org/jira/browse/HDFS-5564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13836820#comment-13836820
]
Colin Patrick McCabe commented on HDFS-5564:
--------------------------------------------
another miscellaneous cleanup to do here:
{{DistributedFileSystem#addCacheDirective}} should fail if an ID is set. It's
a trivial fix (validate that it's not set in {{CacheManager#addDirective}}, a
function the edit log loader code does not use.) We also should add a unit
test for this.
> Refactor tests in TestCacheDirectives
> -------------------------------------
>
> Key: HDFS-5564
> URL: https://issues.apache.org/jira/browse/HDFS-5564
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: datanode, namenode
> Affects Versions: 3.0.0
> Reporter: Andrew Wang
> Assignee: Andrew Wang
> Priority: Trivial
>
> Some of the tests in TestCacheDirectives start their own MiniDFSCluster to
> get a new config, even though we already start a cluster in the @Before
> function. This contributes to longer test runs and code duplication.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
