[
https://issues.apache.org/jira/browse/HDFS-5588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13836846#comment-13836846
]
Hadoop QA commented on HDFS-5588:
---------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12616598/HDFS-5588-1.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-common-project/hadoop-common.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/5611//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/5611//console
This message is automatically generated.
> Incorrect values of trash configuration and trash emptier state in namenode
> log
> -------------------------------------------------------------------------------
>
> Key: HDFS-5588
> URL: https://issues.apache.org/jira/browse/HDFS-5588
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: hdfs-client, namenode
> Affects Versions: 2.2.0
> Reporter: Adam Kawa
> Attachments: HDFS-5588-1.patch
>
>
> Values of trash configuration and trash emptier state in namenode log are
> displayed in milliseconds (but it should be seconds). This is very confusing
> because it makes you feel that Trash does not remove data or the meaning of
> configuration settings changed.
> {code}
> // org.apache.hadoop.fs.TrashPolicyDefault
> @Override
> public void initialize(Configuration conf, FileSystem fs, Path home) {
> ...
> this.deletionInterval = (long)(conf.getFloat(
> FS_TRASH_INTERVAL_KEY, FS_TRASH_INTERVAL_DEFAULT)
> * MSECS_PER_MINUTE);
> this.emptierInterval = (long)(conf.getFloat(
> FS_TRASH_CHECKPOINT_INTERVAL_KEY,
> FS_TRASH_CHECKPOINT_INTERVAL_DEFAULT)
> * MSECS_PER_MINUTE);
> LOG.info("Namenode trash configuration: Deletion interval = " +
> this.deletionInterval + " minutes, Emptier interval = " +
> this.emptierInterval + " minutes.");
> }
> {code}
> this.deletionInterval and this.emptierInterval are in miliseconds, but the
> LOG.info tells that they are in minutes.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
